chore: Upgrade stackable-operator to 0.110.1#137
chore: Upgrade stackable-operator to 0.110.1#137siegfriedweber wants to merge 15 commits intomainfrom
Conversation
dervoeti
left a comment
There was a problem hiding this comment.
Basically LGTM, but, regarding consistency across our platform, this PR has a few things that differ from the decision:
- No support for
JsonPatches UserProvided(Value)instead ofUserProvided(String)KeyValueConfigOverridesuseBTreeMap<String, Option<String>>instead ofBTreeMap<String, String>(to delete values?)
There are good reasons to do this in this PR, it's cool that Role/RoleGroup config overrides are merged, but for users it might be confusing that some overrides are defined differently for OpenSearch compared to other products.
I'm raising this now because at the moment we could still change the decision (and the implementation in operator-rs) as the other typed config overrides PRs have not been released yet.
@sbernauer @siegfriedweber any opinions on this? For each point, we can decide to live with the difference or to adapt either opensearch-operator or operator-rs.
I can live with not supporting JsonPatches in the OpenSearch operator. But I'd like UserProvided to take a string to that it's always the same way across all types of config files and a user can just paste the config in there. On the other hand it's hopefully not commonly used so it's not that important.
No strong opinion about KeyValueConfigOverrides, maybe we could use BTreeMap<String, Option<String>> in operator-rs as well so OpenSearch operator does not have to define its own struct?
There are several problems with JsonPatch:
I can't think of an OpenSearch setting where a JsonPatch would make sense, but there are a lot of pitfalls, so I would leave it out of the OpenSearch operator. We can also reconsider the decision, especially if the other operators are aligned to the structure of the OpenSearch operator. The other operators currently only use |
OPA uses |
To clarify,
There should be no difference between |
This is just an implementation detail. |
Description
Part of stackabletech/issues#844
Bump
stackable-operatorto 0.110.1:HashMap<String, HashMap<String, String>>config overrides with a typedOpenSearchConfigOverridesstruct that only acceptsopensearch.yml.Definition of Done Checklist
Author
https://testing.stackable.tech/job/opensearch-operator-it-custom/32/
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker